remove page_allocator and reflector Version
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can ensure small-grained memory application without having to apply for a whole page every time. |
|
OMG, bro, why are you still using |
That's a deprecated allocator 😅 when we still used libarchive for extracting. So good find, from your side. |
|
The pr test also passed on Linux, and the segment fault error seemed to be fixed. |
|
|
hendriknielaender
approved these changes
Jun 21, 2024
|
I think we can also remove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed
page_allocator, and use general purpose allocatoradn reflector the
version, improved the readability of some codesBy the way, multiple memory leaks occurred in versions using page_allocator in the past.